Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppcbe-ubuntu1404 jobs are not finishing #789

Closed
refack opened this issue Jul 12, 2017 · 24 comments
Closed

ppcbe-ubuntu1404 jobs are not finishing #789

refack opened this issue Jul 12, 2017 · 24 comments

Comments

@refack
Copy link
Contributor

refack commented Jul 12, 2017

https://ci.nodejs.org/job/node-test-commit-plinux/10137/nodes=ppcbe-ubuntu1404/console
https://ci.nodejs.org/job/node-test-commit-plinux/10138/nodes=ppcbe-ubuntu1404/console
https://ci.nodejs.org/job/node-test-commit-plinux/10139/nodes=ppcbe-ubuntu1404/console

[----------] 3 tests from EnvironmentTest
[ RUN      ] EnvironmentTest.AtExitWithEnvironment
[       OK ] EnvironmentTest.AtExitWithEnvironment (362 ms)
[ RUN      ] EnvironmentTest.AtExitWithArgument
[       OK ] EnvironmentTest.AtExitWithArgument (354 ms)
[ RUN      ] EnvironmentTest.MultipleEnvironmentsPerIsolate
Build was aborted
Run condition [Always] enabling perform for step [[]]

@nodejs/platform-ppc

@Trott
Copy link
Member

Trott commented Jul 12, 2017

I think this is primarily maintained by the IBM folks, so... /ping @mhdawson @gibfahn

@gibfahn
Copy link
Member

gibfahn commented Jul 12, 2017

I think this is primarily maintained by the IBM folks, so... /ping @mhdawson @gibfahn

Yep, we're looking at it (that's who @nodejs/platform-ppc is!)

@gibfahn
Copy link
Member

gibfahn commented Jul 12, 2017

The jobs are hanging here:

out/Release/cctest --gtest_output=tap:cctest.tap
[==========] Running 48 tests from 6 test cases.
[----------] Global test environment set-up.
[----------] 2 tests from Base64Test
[ RUN      ] Base64Test.Encode
[       OK ] Base64Test.Encode (0 ms)
[ RUN      ] Base64Test.Decode
[       OK ] Base64Test.Decode (0 ms)
[----------] 2 tests from Base64Test (0 ms total)

[----------] 3 tests from EnvironmentTest
[ RUN      ] EnvironmentTest.AtExitWithEnvironment
[       OK ] EnvironmentTest.AtExitWithEnvironment (375 ms)
[ RUN      ] EnvironmentTest.AtExitWithArgument
[       OK ] EnvironmentTest.AtExitWithArgument (354 ms)
[ RUN      ] EnvironmentTest.MultipleEnvironmentsPerIsolate

Looks like the hanging test is EnvironmentTest.MultipleEnvironmentsPerIsolate.

@gibfahn
Copy link
Member

gibfahn commented Jul 12, 2017

ps -ef on the machine shows nothing out of the ordinary:

iojs      7205 29041  0 05:31 ?        00:00:00 make test-ci
iojs      9930  7205  0 05:32 ?        00:00:01 out/Release/cctest --gtest_output=tap:cctest.tap
iojs     29038  1005  0 05:30 ?        00:00:00 /bin/sh -xe /tmp/hudson6064430299175217652.sh
iojs     29041 29038  0 05:30 ?        00:00:00 make run-ci -j 2

@mhdawson
Copy link
Member

mhdawson commented Jul 12, 2017

Looking at the recent history I only see a single failure that looks like that hang.

@refack
Copy link
Contributor Author

refack commented Jul 12, 2017

Did anyone add an auto-termination?
This one seems to have stoped on it own
https://ci.nodejs.org/job/node-test-commit-plinux/10156/nodes=ppcbe-ubuntu1404/

[----------] 3 tests from EnvironmentTest
[ RUN      ] EnvironmentTest.AtExitWithEnvironment
[       OK ] EnvironmentTest.AtExitWithEnvironment (369 ms)
[ RUN      ] EnvironmentTest.AtExitWithArgument
[       OK ] EnvironmentTest.AtExitWithArgument (359 ms)
[ RUN      ] EnvironmentTest.MultipleEnvironmentsPerIsolate
make[1]: *** [test-ci] Terminated
make[1]: Leaving directory `/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404'
make: *** [run-ci] Error 2
Build step 'Execute shell' marked build as failure
Run condition [Always] enabling perform for step [[]]
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Sending e-mails to: [email protected] [email protected]
Notifying upstream projects of job completion
Finished: FAILURE

@Trott
Copy link
Member

Trott commented Jul 12, 2017

Yep, we're looking at it (that's who @nodejs/platform-ppc is!)

Oops, I missed that @refack had already pinged that team. Sorry!

@mhdawson
Copy link
Member

The hangs seems to have occurred on both be-1 and be-2 from the history.

@mhdawson
Copy link
Member

Jobs seem to be running/completing on both be-1 and be-2 now. The failures are related to nodejs/node#14177 which is not specific to PPC

@gibfahn
Copy link
Member

gibfahn commented Jul 12, 2017

I killed the out/Release/cctest --gtest_output=tap:cctest.tap process on both machines, this seems to have fixed it, I have no idea why. It was definitely hanging before.

@mhdawson
Copy link
Member

Ok I guess we can just keep an eye on it for today.

@mhdawson
Copy link
Member

Just noticed same failure on arm job as well: https://ci.nodejs.org/job/node-test-commit-arm/10826/nodes=armv7-wheezy/console

@refack
Copy link
Contributor Author

refack commented Jul 12, 2017

@mhdawson
Copy link
Member

No instance of cctest running this time on the machine.

@Trott
Copy link
Member

Trott commented Jul 12, 2017

@mhdawson
Copy link
Member

mhdawson commented Jul 12, 2017

This is the test

TEST_F(EnvironmentTest, MultipleEnvironmentsPerIsolate) {
  const v8::HandleScope handle_scope(isolate_);
  const Argv argv;
  Env env1 {handle_scope, isolate_, argv};
  Env env2 {handle_scope, isolate_, argv};

  AtExit(*env1, at_exit_callback1);
  AtExit(*env2, at_exit_callback2);
  RunAtExit(*env1);
  EXPECT_TRUE(called_cb_1);
  EXPECT_FALSE(called_cb_2);

  RunAtExit(*env2);
  EXPECT_TRUE(called_cb_2);
}

From
test/cctest/test_environment.cc

@jBarz
Copy link
Contributor

jBarz commented Jul 12, 2017

I will investigate this and provide an update

@mhdawson
Copy link
Member

@jBarz thanks :)

@refack
Copy link
Contributor Author

refack commented Jul 12, 2017

@refack
Copy link
Contributor Author

refack commented Jul 12, 2017

@mhdawson
Copy link
Member

Given that we now have seen this on centos and ARM in addition to PPC, this should likely be moved to the normal repo as a problem with the test across platforms. @refack any objections ?

@mhdawson
Copy link
Member

My guess is that disabling snapshots has shifted the timing to expose and existing problem either in the test or v8 itself.

@refack
Copy link
Contributor Author

refack commented Jul 12, 2017

No objection, just a suggestion to implement some sort of timeout on jobs spawned by node-test-commit, they should not run (actual time on runners) more the 2h...

@refack
Copy link
Contributor Author

refack commented Jul 12, 2017

Closing in favor of nodejs/node#14206

@refack refack closed this as completed Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants