Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export not detected #20

Open
nicolo-ribaudo opened this issue Oct 27, 2020 · 2 comments
Open

Export not detected #20

nicolo-ribaudo opened this issue Oct 27, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@nicolo-ribaudo
Copy link
Contributor

⚠️ This is not real-world code. It's technically a bug, but no real program will notice it. Feel free to close this issue!

Consider this non-strict mode code: (GitHub's syntax highlighting is broken)

function fn() {
    yield / "/ //" /*
}
/*/
}

module.exports.foo = 2;

// */

The tokens are:

[function] [Identifier: fn] [paren left] [paren left] [brace left]
[Identifier: yield] [division] [String: "/ //"] [Comment: \n}\n/ ]
[brace right]

[Identifier: module] [dot] [Identifier: exports] [dot] [Identifier: foo] [equal] [Number: 2] [semicolon]

However, cjs-module-lexer returns { exports: [], reexports: [] }.

@guybedford
Copy link
Collaborator

Improving the lexing ambiguity cases is always a goal so thanks for posting, but yes there isn't a rush to fix this :)

I wasn't aware the this would be parsed as division in this expression position... what is it that makes yield act differently to return here?

@guybedford
Copy link
Collaborator

I've posted a potential fix in #21, interestingly it's a negative diff and thankfully doesn't require any extra work :)

Would be grateful if you could review when you can.

@guybedford guybedford changed the title Export not detected (edge case) Export not detected Dec 10, 2023
@guybedford guybedford added bug Something isn't working and removed edge case labels Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants