Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy rules from nodejs/node #1

Open
nschonni opened this issue Jan 4, 2022 · 5 comments
Open

Copy rules from nodejs/node #1

nschonni opened this issue Jan 4, 2022 · 5 comments

Comments

@nschonni
Copy link
Member

nschonni commented Jan 4, 2022

copy over rules from https://github.com/nodejs/node/tree/master/tools/eslint-rules

@bnb
Copy link

bnb commented Jun 12, 2022

this seems to be mostly done?

@aduh95
Copy link

aduh95 commented Jun 12, 2022

We probably want some automation to keep both repos in sync.

@bnb
Copy link

bnb commented Jun 12, 2022

@aduh95 perhaps it's worth vendoring from this repo like we do with the remark plugins, so there's a single source of truth?

@aduh95
Copy link

aduh95 commented Jun 13, 2022

Keeping it on the node repo simplifies the dev process and linter changes are more likely to get more reviews. That being said, having a single source of truth may be worth it anyway, so I’m not opposed to vendoring it if someone wants to champion the initiative.

@bnb
Copy link

bnb commented Jun 15, 2022

@nschonni would you be interested in that solution at all? If so, would you want to champion it, or would you prefer someone else did?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants