Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add N-API to main CiTGM runs #234

Closed
mhdawson opened this issue Mar 8, 2018 · 4 comments
Closed

Add N-API to main CiTGM runs #234

mhdawson opened this issue Mar 8, 2018 · 4 comments

Comments

@mhdawson
Copy link
Member

mhdawson commented Mar 8, 2018

We should work on adding

bcrypt-n-api - in Lexgenda Search engine
node-zopfli in Microsoft Edge Developer Portal
[email protected] in CANPIE

There is additional real world usage through:

ffi-napi
weak-napi
ref-napi

to the main GiTGM runs

@addaleax can you confirm ffi-napi, weak-napi and ref-napi are suitable to add to CiTGM

@gabrielschulhof is it feasible to add iotivity-node. I think the answer might be no but asking to make sure

@NickNaso do you think there will be any complications with adding bcrypt ? Does the test need anything external or does an npm install/npm test just work ?

@mcollina
Copy link
Member

mcollina commented Mar 8, 2018

@mafintosh has ported some of his modules to n-api too.

@NickNaso
Copy link
Member

NickNaso commented Mar 8, 2018

@mhdawson I think that for bcrypt npm install/npm test should work

@mafintosh
Copy link
Member

@mhdawson
Copy link
Member Author

mhdawson commented Dec 7, 2020

N-API was taken out of experimental a long time ago and we seem to have been ok, closing

@mhdawson mhdawson closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants