From 374a1d81bb4b5eb3dc43795955d36a9d0103c295 Mon Sep 17 00:00:00 2001 From: Kunal Pathak Date: Tue, 14 Mar 2017 18:14:23 -0700 Subject: [PATCH] test,chakrashim: Updated v8-version test: more chakrashim test fixes PR-URL: nodejs/node-chakracore#186 Reviewed-By: Hitesh Kanwathirtha --- deps/chakrashim/include/v8-version.h | 2 +- test/inspector/inspector.status | 3 ++- test/parallel/parallel.status | 2 +- test/parallel/test-util-format.js | 15 +++++++++++++-- 4 files changed, 17 insertions(+), 5 deletions(-) diff --git a/deps/chakrashim/include/v8-version.h b/deps/chakrashim/include/v8-version.h index 7c8bab9546c..ff9450b471d 100644 --- a/deps/chakrashim/include/v8-version.h +++ b/deps/chakrashim/include/v8-version.h @@ -34,7 +34,7 @@ #define V8_MAJOR_VERSION 5 #define V8_MINOR_VERSION 6 #define V8_BUILD_NUMBER 326 -#define V8_PATCH_LEVEL 55 +#define V8_PATCH_LEVEL 56 // Use 1 for candidates and 0 otherwise. // (Boolean macro values are not supported by all preprocessors.) diff --git a/test/inspector/inspector.status b/test/inspector/inspector.status index b3175eb0fb9..38f1a6c3ccb 100644 --- a/test/inspector/inspector.status +++ b/test/inspector/inspector.status @@ -11,4 +11,5 @@ prefix inspector [$jsEngine==chakracore] test-inspector : SKIP test-inspector-stops-no-file : SKIP -test-not-blocked-on-idle : SKIP \ No newline at end of file +test-not-blocked-on-idle : SKIP +test-inspector-ip-detection : SKIP \ No newline at end of file diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index 772a691278e..18961bbf3a8 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -77,7 +77,7 @@ test-vm-timeout : SKIP test-whatwg-url-origin-for : SKIP test-assert-checktag : SKIP test-process-env-symbols : SKIP -test-util-format : SKIP +test-module-loading-globalpaths : SKIP [$jsEngine==chakracore && $arch==x64] test-buffer-includes : SKIP diff --git a/test/parallel/test-util-format.js b/test/parallel/test-util-format.js index a57a8094ac0..e64eb1b25cd 100644 --- a/test/parallel/test-util-format.js +++ b/test/parallel/test-util-format.js @@ -20,7 +20,7 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -require('../common'); +const common = require('../common'); const assert = require('assert'); const util = require('util'); const symbol = Symbol('foo'); @@ -83,7 +83,18 @@ assert.strictEqual(util.format('o: %j, a: %j'), 'o: %j, a: %j'); { const o = {}; o.o = o; - assert.strictEqual(util.format('%j', o), '[Circular]'); + if (!common.isChakraEngine) { + assert.strictEqual(util.format('%j', o), '[Circular]'); + } else { + assert.throws(() => { util.format('%j', o); }, function(err) { + if (err instanceof TypeError && + err.message === 'Circular reference in value argument not ' + + 'supported') { + return true; + } + return false; + }); + } } {