From 00dd9738eeeac371f89cdb9dd0f9e759f6c5c6e0 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Tue, 18 Sep 2018 13:26:22 +0200 Subject: [PATCH] doc: specify fast-tracking MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently the documentation is not specific how fast-tracking should be applied. This specifies exactly how things should be done to prevent confusion. PR-URL: https://github.com/nodejs/node/pull/22929 Reviewed-By: Denys Otrishko Reviewed-By: Anna Henningsen Reviewed-By: Tobias Nießen Reviewed-By: Vse Mozhet Byt Reviewed-By: John-David Dalton Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca Reviewed-By: Michaël Zasso Reviewed-By: Weijia Wang Reviewed-By: Richard Lau Reviewed-By: Matheus Marchini Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Yuta Hiroto Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat Reviewed-By: George Adams --- COLLABORATOR_GUIDE.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index c073c07a7f0996..0c03e89a077252 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -183,9 +183,12 @@ can be fast-tracked and may be landed after a shorter delay. For example: * Regressions that happen right before a release, or reported soon after. When a pull request is deemed suitable to be fast-tracked, label it with -`fast-track`. The pull request can be landed once 2 or more Collaborators -approve both the pull request and the fast-tracking request, and the necessary -CI testing is done. +`fast-track` and add a comment that collaborators may upvote. Please mention the +collaborators that gave an approval before in that comment. If someone disagrees +with the fast-tracking request, remove the label and leave a comment why it +should not be fast-tracked. The pull request can be landed once 2 or more +Collaborators approve both the pull request and the fast-tracking request, and +the necessary CI testing is done. ### Testing and CI