From 033773c17bd20fb53b1fd9fdbfa2ada019580104 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Thu, 10 Aug 2017 20:48:18 +0200 Subject: [PATCH] src: add overlooked handle to cleanup The `Environment::destroy_ids_timer_handle` should be cleaned up by `Environment::CleanupHandles()`. Fix that by adding it to the list. This partially fixes a cctest. Ref: https://github.com/nodejs/node/issues/14206 PR-URL: https://github.com/nodejs/node/pull/14749 Reviewed-By: Refael Ackermann Reviewed-By: Ben Noordhuis Reviewed-By: Ben Noordhuis Reviewed-By: Daniel Bevenius --- src/env.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/env.cc b/src/env.cc index 0087f719dc00db..5bd75abab34512 100644 --- a/src/env.cc +++ b/src/env.cc @@ -76,6 +76,10 @@ void Environment::Start(int argc, reinterpret_cast(&idle_check_handle_), close_and_finish, nullptr); + RegisterHandleCleanup( + reinterpret_cast(&destroy_ids_timer_handle_), + close_and_finish, + nullptr); if (start_profiler_idle_notifier) { StartProfilerIdleNotifier();