Skip to content

Commit

Permalink
doc: update default branch name in test/**
Browse files Browse the repository at this point in the history
Refs: #33864

PR-URL: #43445
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
  • Loading branch information
lpinca authored and targos committed Jul 12, 2022
1 parent a23051a commit 038decf
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions test/doctool/test-doctool-versions.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ for (const version of versions) {
// Check that the minimum number of versions were returned.
// Later versions are allowed, but not checked for here (they were checked
// above).
// Also check for the previous semver major -- From master this will be the
// most recent major release.
// Also check for the previous semver major -- From the main branch this will be
// the most recent major release.
const thisMajor = Number.parseInt(process.versions.node.split('.')[0]);
const prevMajorString = `${thisMajor - 1}.x`;
if (!expected.includes(prevMajorString)) {
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/package-main-enoent/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
// The path in "main" in "package.json" does not exist here, but it does in
// the copy in node_modules. This is being tested because bluebird tests depend
// on this behavior and it was accidentally broken by a seemingly unrelated
// commit on master.
// commit on the main branch.

require('package-main-enoent');
2 changes: 1 addition & 1 deletion test/parallel/test-fs-promises-file-handle-readFile.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ async function doReadAndCancel() {

// Validate file size is within range for reading
{
// Variable taken from https://github.com/nodejs/node/blob/master/lib/internal/fs/promises.js#L5
// Variable taken from https://github.com/nodejs/node/blob/1377163f3351/lib/internal/fs/promises.js#L5
const kIoMaxLength = 2 ** 31 - 1;

const newFile = path.resolve(tmpDir, 'dogs-running3.txt');
Expand Down
2 changes: 1 addition & 1 deletion test/wpt/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,4 +167,4 @@ In that case it needs to be marked with `skip` instead of `fail`.

[Web Platform Tests]: https://github.com/web-platform-tests/wpt
[`test/fixtures/wpt/README.md`]: ../fixtures/wpt/README.md
[git node wpt]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-wpt
[git node wpt]: https://github.com/nodejs/node-core-utils/blob/HEAD/docs/git-node.md#git-node-wpt

0 comments on commit 038decf

Please sign in to comment.