tools: fix ICU shrinker and docs

- tools: path to ICU datafile moved - docs: configure is now configure.py Fixes: #23245 PR-URL: #23266 Reviewed-By: Refael Ackermann <[email protected]>
nodejs · Oct 7, 2018 · 1010ef5 · 1010ef5
1 parent cb68188
commit 1010ef5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tools/icu/README.md b/tools/icu/README.md
@@ -92,7 +92,7 @@ make clean
 tools/license-builder.sh
 ```
 
-- Now, fix the default URL for the `full-icu` build in `/configure`, in
+- Now, fix the default URL for the `full-icu` build in `/configure.py`, in
 the `configure_intl()` function. It should match the ICU URL used in the
 first step.  When this is done, the following should build with full ICU.
 
@@ -104,7 +104,7 @@ make
 make test-ci
 ```
 
-- commit the change to `configure` along with the updated `LICENSE` file.
+- commit the change to `configure.py` along with the updated `LICENSE` file.
 
   - Note: To simplify review, I often will “pre-land” this patch, meaning that
   I run the patch through `curl -L https://github.com/nodejs/node/pull/xxx.patch

diff --git a/tools/icu/shrink-icu-src.py b/tools/icu/shrink-icu-src.py
@@ -22,7 +22,7 @@
 parser.add_option('--icutmp',
     action='store',
     dest='icutmp',
-    default='out/Release/gen/icutmp',
+    default='out/Release/obj/gen/icutmp',
     help='path to icutmp dir.')