assert: support symbols as assertion messages

Currently, assertion messages are implicitly converted to strings, which causes symbols to throw. This commit adds an explicit string conversion. PR-URL: #20693 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · May 22, 2018 · 1160d61 · 1160d61
1 parent 0d28b4b
commit 1160d61
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/internal/assert.js b/lib/internal/assert.js
@@ -196,7 +196,7 @@ class AssertionError extends Error {
     } = options;
 
     if (message != null) {
-      super(message);
+      super(String(message));
     } else {
       if (process.stdout.isTTY) {
         // Reset on each call to make sure we handle dynamically set environment

diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -640,6 +640,16 @@ common.expectsError(
   }
 );
 
+common.expectsError(
+  () => assert(false, Symbol('foo')),
+  {
+    code: 'ERR_ASSERTION',
+    type: assert.AssertionError,
+    generatedMessage: false,
+    message: 'Symbol(foo)'
+  }
+);
+
 {
   // Test caching.
   const fs = process.binding('fs');