src: make req_wrap a unique_ptr in AfterConnect

PR-URL: #23115 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Oct 3, 2018 · 20a4f14 · 20a4f14
1 parent ce7fad5
commit 20a4f14
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/connection_wrap.cc b/src/connection_wrap.cc
@@ -77,7 +77,8 @@ void ConnectionWrap<WrapType, UVType>::OnConnection(uv_stream_t* handle,
 template <typename WrapType, typename UVType>
 void ConnectionWrap<WrapType, UVType>::AfterConnect(uv_connect_t* req,
                                                     int status) {
-  ConnectWrap* req_wrap = static_cast<ConnectWrap*>(req->data);
+  std::unique_ptr<ConnectWrap> req_wrap
+    (static_cast<ConnectWrap*>(req->data));
   CHECK_NOT_NULL(req_wrap);
   WrapType* wrap = static_cast<WrapType*>(req->handle->data);
   CHECK_EQ(req_wrap->env(), wrap->env());
@@ -108,8 +109,6 @@ void ConnectionWrap<WrapType, UVType>::AfterConnect(uv_connect_t* req,
   };
 
   req_wrap->MakeCallback(env->oncomplete_string(), arraysize(argv), argv);
-
-  delete req_wrap;
 }
 
 template ConnectionWrap<PipeWrap, uv_pipe_t>::ConnectionWrap(