From 27c5e96ffeb8fbdc40a6f99b669bc76dc0ee0e0b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 11 Aug 2018 20:57:01 -0700 Subject: [PATCH] doc: leave pull requests open for 72 hours MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, we have a 48/72 rule for how many hours a pull request should be left open at a minimum. Unfortunately, whether a pull request should be left open for 48 or 72 hours is often unclear. The 72 hours is required if it is a weekend. If I open a pull request on a Friday morning, does it need to stay open 48 hours or 72 or something in between? Does it matter if I'm in one time zone or another? The 48/72 rule predates our fast-tracking process. Given the ability to fast-track trivial pull requests, there should be little disadvantage to leaving significant changes open for 72 hours instead of 48 hours, and arguably considerable advantage in terms of allowing people sufficient time to review things. So to simplify, standardize on 72 hours. Weekend or not, 72 hours. Easy. PR-URL: https://github.com/nodejs/node/pull/22275 Reviewed-By: John-David Dalton Reviewed-By: Trivikram Kamat Reviewed-By: Сковорода Никита Андреевич Reviewed-By: Benjamin Gruenbaum Reviewed-By: Brian White Reviewed-By: Jon Moss Reviewed-By: Colin Ihrig Reviewed-By: Ben Coe Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Refael Ackermann Reviewed-By: João Reis Reviewed-By: Michael Dawson Reviewed-By: Rod Vagg --- COLLABORATOR_GUIDE.md | 8 ++++---- doc/onboarding.md | 5 ++--- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 513faa46c8ab34..75b3c5e6c2e068 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -171,10 +171,10 @@ agenda. ### Waiting for Approvals Before landing pull requests, sufficient time should be left for input -from other Collaborators. In general, leave at least 48 hours during the -week and 72 hours over weekends to account for international time -differences and work schedules. However, certain types of pull requests -can be fast-tracked and may be landed after a shorter delay. For example: +from other Collaborators. In general, leave at least 72 hours to account for +international time differences and work schedules. However, certain types of +pull requests can be fast-tracked and may be landed after a shorter delay. For +example: * Focused changes that affect only documentation and/or the test suite: * `code-and-learn` tasks typically fall into this category. diff --git a/doc/onboarding.md b/doc/onboarding.md index 3a03edb17e8169..bd9418fd91f9c1 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -138,8 +138,7 @@ onboarding session. * There is a minimum waiting time which we try to respect for non-trivial changes so that people who may have important input in such a distributed project are able to respond. - * For non-trivial changes, leave the pull request open for at least 48 hours - (72 hours on a weekend). + * For non-trivial changes, leave the pull request open for at least 72 hours. * If a pull request is abandoned, check if they'd mind if you took it over (especially if it just has nits left). * Approving a change @@ -215,7 +214,7 @@ needs to be pointed out separately during the onboarding. * Run CI on the PR. Because the PR does not affect any code, use the `node-test-pull-request-lite-pipeline` CI task. * After one or two approvals, land the PR (PRs of this type do not need to wait - for 48/72 hours to land). + for 72 hours to land). * Be sure to add the `PR-URL: ` and appropriate `Reviewed-By:` metadata. * [`node-core-utils`][] automates the generation of metadata and the landing