src: do not read string out of bounds

PR-URL: #51358 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Keyhan Vakil <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
nodejs · Feb 15, 2024 · 36e42aa · 36e42aa
1 parent 4d06d80
commit 36e42aa
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/path.cc b/src/path.cc
@@ -24,15 +24,14 @@ std::string NormalizeString(const std::string_view path,
   int lastSegmentLength = 0;
   int lastSlash = -1;
   int dots = 0;
-  char code;
-  const auto pathLen = path.size();
-  for (uint8_t i = 0; i <= pathLen; ++i) {
-    if (i < pathLen) {
+  char code = 0;
+  for (size_t i = 0; i <= path.size(); ++i) {
+    if (i < path.size()) {
       code = path[i];
-    } else if (IsPathSeparator(path[i])) {
+    } else if (IsPathSeparator(code)) {
       break;
     } else {
-      code = node::kPathSeparator;
+      code = '/';
     }
 
     if (IsPathSeparator(code)) {