From 3f6d80e25c8dcab0a804a2c9dad94573e2cf2488 Mon Sep 17 00:00:00 2001
From: Taylor Woll <taylor.woll@microsoft.com>
Date: Tue, 16 Jan 2018 21:17:25 -0800
Subject: [PATCH] n-api,test: add a new.target test to addons-napi

Added a N-API test to verify new.target behavior.

Backport-PR-URL: https://github.com/nodejs/node/pull/19447
PR-URL: https://github.com/nodejs/node/pull/19236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
---
 test/addons-napi/test_new_target/binding.c   | 69 ++++++++++++++++++++
 test/addons-napi/test_new_target/binding.gyp |  9 +++
 test/addons-napi/test_new_target/test.js     | 21 ++++++
 3 files changed, 99 insertions(+)
 create mode 100644 test/addons-napi/test_new_target/binding.c
 create mode 100644 test/addons-napi/test_new_target/binding.gyp
 create mode 100644 test/addons-napi/test_new_target/test.js

diff --git a/test/addons-napi/test_new_target/binding.c b/test/addons-napi/test_new_target/binding.c
new file mode 100644
index 00000000000000..a74d4bb2f877be
--- /dev/null
+++ b/test/addons-napi/test_new_target/binding.c
@@ -0,0 +1,69 @@
+#include <node_api.h>
+#include "../common.h"
+
+napi_value BaseClass(napi_env env, napi_callback_info info) {
+  napi_value newTargetArg;
+  NAPI_CALL(env, napi_get_new_target(env, info, &newTargetArg));
+  napi_value thisArg;
+  NAPI_CALL(env, napi_get_cb_info(env, info, NULL, NULL, &thisArg, NULL));
+  napi_value undefined;
+  NAPI_CALL(env, napi_get_undefined(env, &undefined));
+
+  // this !== new.target since we are being invoked through super()
+  bool result;
+  NAPI_CALL(env, napi_strict_equals(env, newTargetArg, thisArg, &result));
+  NAPI_ASSERT(env, !result, "this !== new.target");
+
+  // new.target !== undefined because we should be called as a new expression
+  NAPI_ASSERT(env, newTargetArg != NULL, "newTargetArg != NULL");
+  NAPI_CALL(env, napi_strict_equals(env, newTargetArg, undefined, &result));
+  NAPI_ASSERT(env, !result, "new.target !== undefined");
+
+  return thisArg;
+}
+
+napi_value Constructor(napi_env env, napi_callback_info info) {
+  bool result;
+  napi_value newTargetArg;
+  NAPI_CALL(env, napi_get_new_target(env, info, &newTargetArg));
+  size_t argc = 1;
+  napi_value argv;
+  napi_value thisArg;
+  NAPI_CALL(env, napi_get_cb_info(env, info, &argc, &argv, &thisArg, NULL));
+  napi_value undefined;
+  NAPI_CALL(env, napi_get_undefined(env, &undefined));
+
+  // new.target !== undefined because we should be called as a new expression
+  NAPI_ASSERT(env, newTargetArg != NULL, "newTargetArg != NULL");
+  NAPI_CALL(env, napi_strict_equals(env, newTargetArg, undefined, &result));
+  NAPI_ASSERT(env, !result, "new.target !== undefined");
+
+  // arguments[0] should be Constructor itself (test harness passed it)
+  NAPI_CALL(env, napi_strict_equals(env, newTargetArg, argv, &result));
+  NAPI_ASSERT(env, result, "new.target === Constructor");
+
+  return thisArg;
+}
+
+napi_value OrdinaryFunction(napi_env env, napi_callback_info info) {
+  napi_value newTargetArg;
+  NAPI_CALL(env, napi_get_new_target(env, info, &newTargetArg));
+
+  NAPI_ASSERT(env, newTargetArg == NULL, "newTargetArg == NULL");
+
+  napi_value _true;
+  NAPI_CALL(env, napi_get_boolean(env, true, &_true));
+  return _true;
+}
+
+napi_value Init(napi_env env, napi_value exports) {
+  const napi_property_descriptor desc[] = {
+    DECLARE_NAPI_PROPERTY("BaseClass", BaseClass),
+    DECLARE_NAPI_PROPERTY("OrdinaryFunction", OrdinaryFunction),
+    DECLARE_NAPI_PROPERTY("Constructor", Constructor)
+  };
+  NAPI_CALL(env, napi_define_properties(env, exports, 3, desc));
+  return exports;
+}
+
+NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
diff --git a/test/addons-napi/test_new_target/binding.gyp b/test/addons-napi/test_new_target/binding.gyp
new file mode 100644
index 00000000000000..23daf507916ff6
--- /dev/null
+++ b/test/addons-napi/test_new_target/binding.gyp
@@ -0,0 +1,9 @@
+{
+  'targets': [
+    {
+      'target_name': 'binding',
+      'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
+      'sources': [ 'binding.c' ]
+    }
+  ]
+}
diff --git a/test/addons-napi/test_new_target/test.js b/test/addons-napi/test_new_target/test.js
new file mode 100644
index 00000000000000..702e8ca8b4387d
--- /dev/null
+++ b/test/addons-napi/test_new_target/test.js
@@ -0,0 +1,21 @@
+'use strict';
+
+const common = require('../../common');
+const assert = require('assert');
+const binding = require(`./build/${common.buildType}/binding`);
+
+class Class extends binding.BaseClass {
+  constructor() {
+    super();
+    this.method();
+  }
+  method() {
+    this.ok = true;
+  }
+}
+
+assert.ok(new Class() instanceof binding.BaseClass);
+assert.ok(new Class().ok);
+assert.ok(binding.OrdinaryFunction());
+assert.ok(
+  new binding.Constructor(binding.Constructor) instanceof binding.Constructor);