From 41ff1bb9c7f6b06e809ca9c46794a4765eeb00dc Mon Sep 17 00:00:00 2001 From: Benedikt Meurer Date: Thu, 5 Jul 2018 09:42:52 +0200 Subject: [PATCH] src: prepare for V8 Swallowed Rejection Hook This is done in preparation for landing https://chromium-review.googlesource.com/c/v8/v8/+/1126099 on the V8 side, which extends the existing PromiseRejectEvent mechanism with new hooks for reject/resolve after a Promise was previously resolved already. Refs: https://github.com/nodejs/promises-debugging/issues/8 Design: https://goo.gl/2stLUY PR-URL: https://github.com/nodejs/node/pull/21838 Reviewed-By: Gus Caplan Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell Reviewed-By: Yang Guo Reviewed-By: Benedikt Meurer --- src/bootstrapper.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc index 8bcc0493f5be6d..5f40d62a82fdef 100644 --- a/src/bootstrapper.cc +++ b/src/bootstrapper.cc @@ -69,7 +69,7 @@ void PromiseRejectCallback(PromiseRejectMessage message) { callback = env->promise_reject_handled_function(); value = Undefined(isolate); } else { - UNREACHABLE(); + return; } Local args[] = { promise, value };