From 4afa7483b1334927864e85957bdd7bcfbfad6866 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 11 Jun 2017 21:10:56 -0700 Subject: [PATCH] test: increase bufsize in child process write test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit test-child-process-stdio-big-write-end was failing on ubuntu1604-arm64 because the while loop that was supposed to fill up the buffer ended up being an infinite loop. This increases the size of the writes in the loop by 1K until the buffer fills up. PR-URL: https://github.com/nodejs/node/pull/13626 Fixes: https://github.com/nodejs/node/issues/13603 Reviewed-By: Refael Ackermann Reviewed-By: Alexey Orlenko Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig --- .../test-child-process-stdio-big-write-end.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/parallel/test-child-process-stdio-big-write-end.js b/test/parallel/test-child-process-stdio-big-write-end.js index 6cc3d86644ac39..2d9234fd480085 100644 --- a/test/parallel/test-child-process-stdio-big-write-end.js +++ b/test/parallel/test-child-process-stdio-big-write-end.js @@ -22,7 +22,7 @@ 'use strict'; require('../common'); const assert = require('assert'); -const BUFSIZE = 1024; +let bufsize = 0; switch (process.argv[2]) { case undefined: @@ -51,14 +51,15 @@ function parent() { // Write until the buffer fills up. let buf; do { - buf = Buffer.alloc(BUFSIZE, '.'); - sent += BUFSIZE; + bufsize += 1024; + buf = Buffer.alloc(bufsize, '.'); + sent += bufsize; } while (child.stdin.write(buf)); // then write a bunch more times. for (let i = 0; i < 100; i++) { - const buf = Buffer.alloc(BUFSIZE, '.'); - sent += BUFSIZE; + const buf = Buffer.alloc(bufsize, '.'); + sent += bufsize; child.stdin.write(buf); }