src: add null check to GetCategoryGroupEnabled()

The input to this function shouldn't be null, and callers are not equipped to deal with a nullptr return value. Change the nullptr return to a CHECK_NOT_NULL(). Also fix the indentation of the function. PR-URL: #21545 Fixes: #19991 Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
nodejs · Jun 28, 2018 · 7acfacb · 7acfacb
1 parent 45fe865
commit 7acfacb
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/node_trace_events.cc b/src/node_trace_events.cc
@@ -95,9 +95,8 @@ static std::unordered_set<std::string> categoryGroups;
 // Gets a pointer to the category-enabled flags for a tracing category group,
 // if tracing is enabled for it.
 static const uint8_t* GetCategoryGroupEnabled(const char* category_group) {
-    if (category_group == nullptr) return nullptr;
-
-    return TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED(category_group);
+  CHECK_NOT_NULL(category_group);
+  return TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED(category_group);
 }
 
 static const char* GetCategoryGroup(Environment* env,