From 83278b23a7d26e7e26fb8c469133c924b50107ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= Date: Thu, 20 Sep 2018 20:55:05 +0200 Subject: [PATCH] test: fix flaky key pair generation test There is a very small chance (about 0.4%) that OpenSSL will successfully decrypt a key without the correct passphrase and will then fail while parsing its ASN.1 structure. In those rare cases, the error message will be different. PR-URL: https://github.com/nodejs/node/pull/22980 Fixes: https://github.com/nodejs/node/issues/22978 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott --- test/parallel/test-crypto-keygen.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-crypto-keygen.js b/test/parallel/test-crypto-keygen.js index f614b09292501e..08e37e2ac0d902 100644 --- a/test/parallel/test-crypto-keygen.js +++ b/test/parallel/test-crypto-keygen.js @@ -169,7 +169,7 @@ function convertDERToPEM(label, der) { // Since the private key is encrypted, signing shouldn't work anymore. assert.throws(() => { testSignVerify(publicKey, privateKey); - }, /bad decrypt/); + }, /bad decrypt|asn1 encoding routines/); // Signing should work with the correct password. testSignVerify(publicKey, { @@ -232,7 +232,7 @@ function convertDERToPEM(label, der) { // Since the private key is encrypted, signing shouldn't work anymore. assert.throws(() => { testSignVerify(publicKey, privateKey); - }, /bad decrypt/); + }, /bad decrypt|asn1 encoding routines/); testSignVerify(publicKey, { key: privateKey,