src: add SafeGetenv() to internal API

Allow it to be used anywhere in src/ that env variables with security implications are accessed. PR-URL: #11006 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Feb 22, 2017 · 8be6702 · 8be6702
1 parent a8613f8
commit 8be6702
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/node.cc b/src/node.cc
@@ -901,7 +901,7 @@ Local<Value> UVException(Isolate* isolate,
 
 
 // Look up environment variable unless running as setuid root.
-inline bool SafeGetenv(const char* key, std::string* text) {
+bool SafeGetenv(const char* key, std::string* text) {
 #ifndef _WIN32
   // TODO(bnoordhuis) Should perhaps also check whether getauxval(AT_SECURE)
   // is non-zero on Linux.

diff --git a/src/node_internals.h b/src/node_internals.h
@@ -108,6 +108,8 @@ void RegisterSignalHandler(int signal,
                            bool reset_handler = false);
 #endif
 
+bool SafeGetenv(const char* key, std::string* text);
+
 template <typename T, size_t N>
 constexpr size_t arraysize(const T(&)[N]) { return N; }