From 94dd42577c8aa3a3c2f812ad68b3fe55da546eb5 Mon Sep 17 00:00:00 2001 From: Jimmy Thomson Date: Thu, 6 Jul 2017 11:42:28 -0700 Subject: [PATCH] test: fix cctest failure on Windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Linux converts the ipv6 address "::" to "::1", while windows does not. By explicitly using "::1" in the test we allow it to succeed on windows. PR-URL: https://github.com/nodejs/node/pull/14111 Reviewed-By: Refael Ackermann Reviewed-By: Eugene Ostroukhov Reviewed-By: Colin Ihrig Reviewed-By: Kunal Pathak Reviewed-By: João Reis Reviewed-By: James M Snell --- test/cctest/test_inspector_socket_server.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/cctest/test_inspector_socket_server.cc b/test/cctest/test_inspector_socket_server.cc index 61cf2867291b0a..f9814274d0f91e 100644 --- a/test/cctest/test_inspector_socket_server.cc +++ b/test/cctest/test_inspector_socket_server.cc @@ -621,7 +621,7 @@ TEST_F(InspectorSocketServerTest, BindsToIpV6) { ASSERT_TRUE(server->Start()); SocketWrapper socket1(&loop); - socket1.Connect("::", server.port(), true); + socket1.Connect("::1", server.port(), true); socket1.Write(WsHandshakeRequest(MAIN_TARGET_ID)); socket1.Expect(WS_HANDSHAKE_RESPONSE); server->Stop(ServerHolder::CloseCallback);