test: refactor addons-napi/test_promise/test.js

* remove custom messages for assert that conceal values * add comment explaining test * add block scoping Backport-PR-URL: #19447 PR-URL: #16814 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Apr 16, 2018 · 976f32d · 976f32d
1 parent 22490dc
commit 976f32d
Showing 1 changed file with 17 additions and 14 deletions.
diff --git a/test/addons-napi/test_promise/test.js b/test/addons-napi/test_promise/test.js
@@ -1,17 +1,19 @@
 'use strict';
 
 const common = require('../../common');
-const test_promise = require(`./build/${common.buildType}/test_promise`);
+
+// This tests the promise-related n-api calls
+
 const assert = require('assert');
+const test_promise = require(`./build/${common.buildType}/test_promise`);
 
 // A resolution
 {
   const expected_result = 42;
   const promise = test_promise.createPromise();
   promise.then(
     common.mustCall(function(result) {
-      assert.strictEqual(result, expected_result,
-                         `promise resolved as expected, received ${result}`);
+      assert.strictEqual(result, expected_result);
     }),
     common.mustNotCall());
   test_promise.concludeCurrentPromise(expected_result, true);
@@ -24,23 +26,24 @@ const assert = require('assert');
   promise.then(
     common.mustNotCall(),
     common.mustCall(function(result) {
-      assert.strictEqual(result, expected_result,
-                         `promise rejected as expected, received ${result}`);
+      assert.strictEqual(result, expected_result);
     }));
   test_promise.concludeCurrentPromise(expected_result, false);
 }
 
 // Chaining
-const promise = test_promise.createPromise();
-promise.then(
-  common.mustCall(function(result) {
-    assert.strictEqual(result, 'chained answer',
-                       'resolving with a promise chains properly');
-  }),
-  common.mustNotCall());
-test_promise.concludeCurrentPromise(Promise.resolve('chained answer'), true);
+{
+  const expected_result = 'chained answer';
+  const promise = test_promise.createPromise();
+  promise.then(
+    common.mustCall(function(result) {
+      assert.strictEqual(result, expected_result);
+    }),
+    common.mustNotCall());
+  test_promise.concludeCurrentPromise(Promise.resolve('chained answer'), true);
+}
 
-assert.strictEqual(test_promise.isPromise(promise), true);
+assert.strictEqual(test_promise.isPromise(test_promise.createPromise()), true);
 assert.strictEqual(test_promise.isPromise(Promise.reject(-1)), true);
 assert.strictEqual(test_promise.isPromise(2.4), false);
 assert.strictEqual(test_promise.isPromise('I promise!'), false);