From 9ee271d92b856abb89d0ca66ecd8e17c1b23fe18 Mon Sep 17 00:00:00 2001 From: Kyle Farnung Date: Thu, 6 Jul 2017 16:03:27 -0700 Subject: [PATCH] build: split up cpplint to avoid long cmd lines MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refactors cpplint slightly to allow multiple runs of it. This allows downstream projects to run cpplint on their dependencies. PR-URL: https://github.com/nodejs/node/pull/14116 Reviewed-By: Refael Ackermann Reviewed-By: Kunal Pathak Reviewed-By: João Reis --- vcbuild.bat | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/vcbuild.bat b/vcbuild.bat index 0af8047e4a0e96..03cf82565d4a7a 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -435,12 +435,16 @@ goto cpplint :cpplint if not defined cpplint goto jslint -echo running cpplint +call :run-cpplint src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h test\gc\binding.cc tools\icu\*.cc tools\icu\*.h +call :run-python tools/check-imports.py +goto jslint + +:run-cpplint +if "%*"=="" goto exit +echo running cpplint '%*' set cppfilelist= setlocal enabledelayedexpansion -for /f "tokens=*" %%G in ('dir /b /s /a src\*.c src\*.cc src\*.h ^ -test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h ^ -test\gc\binding.cc tools\icu\*.cc tools\icu\*.h') do ( +for /f "tokens=*" %%G in ('dir /b /s /a %*') do ( set relpath=%%G set relpath=!relpath:*%~dp0=! call :add-to-list !relpath! @@ -449,8 +453,7 @@ test\gc\binding.cc tools\icu\*.cc tools\icu\*.h') do ( set cppfilelist=%localcppfilelist% ) call :run-python tools/cpplint.py %cppfilelist% -call :run-python tools/check-imports.py -goto jslint +goto exit :add-to-list echo %1 | findstr /c:"src\node_root_certs.h"