From a8f78f02cb05f1346110f0f1a61e63109e8ff38c Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 19 Dec 2018 21:50:28 +0100 Subject: [PATCH] src: fulfill Maybe contract in InlineDecoder Use an empty/nothing `Maybe<>` to indicate a pending exception. PR-URL: https://github.com/nodejs/node/pull/25140 Reviewed-By: Colin Ihrig Reviewed-By: Joyee Cheung Reviewed-By: Shelley Vohr Reviewed-By: James M Snell --- src/string_bytes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/string_bytes.h b/src/string_bytes.h index 87a296663e15aa..62a67247375518 100644 --- a/src/string_bytes.h +++ b/src/string_bytes.h @@ -42,7 +42,7 @@ class StringBytes { enum encoding enc = ParseEncoding(env->isolate(), encoding, _default); if (!StringBytes::IsValidString(string, enc)) { env->ThrowTypeError("Bad input string"); - return v8::Just(false); + return v8::Nothing(); } size_t storage;