test: verify arguments length in common.expectsError

If `common.expectsError` is used as a callback, it will now also verify that there is only one argument (the expected error). Backport-PR-URL: #22850 PR-URL: #20311 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Oct 16, 2018 · aa341d1 · aa341d1
1 parent 28a6e59
commit aa341d1
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/test/common/index.js b/test/common/index.js
@@ -691,6 +691,11 @@ exports.expectsError = function expectsError(fn, settings, exact) {
     fn = undefined;
   }
   function innerFn(error) {
+    if (arguments.length !== 1) {
+      // Do not use `assert.strictEqual()` to prevent `util.inspect` from
+      // always being called.
+      assert.fail(`Expected one argument, got ${util.inspect(arguments)}`);
+    }
     assert.strictEqual(error.code, settings.code);
     const descriptor = Object.getOwnPropertyDescriptor(error, 'message');
     assert.strictEqual(descriptor.enumerable,