From b523f13fa218f39d965e41be5bc3a14d59d264ea Mon Sep 17 00:00:00 2001 From: Tom White Date: Fri, 5 Oct 2018 15:00:16 -0700 Subject: [PATCH] test: add module require tests for certain package.json errors test for unusual error cases: verify that module require() falls back to index if package.json names a missing file and throws an error if package.json is unparseable. PR-URL: https://github.com/nodejs/node/pull/23285 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig --- test/fixtures/packages/missing-main/index.js | 22 +++++++++++++++++++ .../packages/missing-main/package.json | 4 ++++ .../packages/unparseable/package.json | 3 +++ test/sequential/test-module-loading.js | 7 ++++++ 4 files changed, 36 insertions(+) create mode 100644 test/fixtures/packages/missing-main/index.js create mode 100644 test/fixtures/packages/missing-main/package.json create mode 100644 test/fixtures/packages/unparseable/package.json diff --git a/test/fixtures/packages/missing-main/index.js b/test/fixtures/packages/missing-main/index.js new file mode 100644 index 00000000000000..c361a6dc8d1950 --- /dev/null +++ b/test/fixtures/packages/missing-main/index.js @@ -0,0 +1,22 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +exports.ok = 'ok'; diff --git a/test/fixtures/packages/missing-main/package.json b/test/fixtures/packages/missing-main/package.json new file mode 100644 index 00000000000000..feb846703ff796 --- /dev/null +++ b/test/fixtures/packages/missing-main/package.json @@ -0,0 +1,4 @@ +{ + "name": "missingmain", + "main": "doesnotexist.js" +} diff --git a/test/fixtures/packages/unparseable/package.json b/test/fixtures/packages/unparseable/package.json new file mode 100644 index 00000000000000..2017a68ecc415c --- /dev/null +++ b/test/fixtures/packages/unparseable/package.json @@ -0,0 +1,3 @@ +{ + "main": "therain" "inspain" +} diff --git a/test/sequential/test-module-loading.js b/test/sequential/test-module-loading.js index c71f9d1edf4d5b..42916a7903c344 100644 --- a/test/sequential/test-module-loading.js +++ b/test/sequential/test-module-loading.js @@ -104,6 +104,12 @@ const d2 = require('../fixtures/b/d'); assert.strictEqual(require('../fixtures/packages/index').ok, 'ok'); assert.strictEqual(require('../fixtures/packages/main').ok, 'ok'); assert.strictEqual(require('../fixtures/packages/main-index').ok, 'ok'); +assert.strictEqual(require('../fixtures/packages/missing-main').ok, 'ok'); + +assert.throws( + function() { require('../fixtures/packages/unparseable'); }, + /^SyntaxError: Error parsing/ +); { console.error('test cycles containing a .. path'); @@ -267,6 +273,7 @@ try { 'fixtures/packages/index/index.js': {}, 'fixtures/packages/main/package-main-module.js': {}, 'fixtures/packages/main-index/package-main-module/index.js': {}, + 'fixtures/packages/missing-main/index.js': {}, 'fixtures/cycles/root.js': { 'fixtures/cycles/folder/foo.js': {} },