tools: build API TOC using raw headers

Markdown interprets the syntax for optional arguments as a form of a link, so instead of trying to build up the contents using the node value, use grab the raw original markup instead. Fixes regression noted in #21490 (comment) PR-URL: #21922 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Jul 21, 2018 · b98bf82 · b98bf82
1 parent eabe907
commit b98bf82
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/tools/doc/html.js b/tools/doc/html.js
@@ -340,8 +340,10 @@ function buildToc({ filename }) {
 
       depth = node.depth;
       const realFilename = path.basename(realFilenames[0], '.md');
-      const headingText = node.children.map((child) => child.value)
-        .join().trim();
+      const headingText = node.children.map((child) =>
+        file.contents.slice(child.position.start.offset,
+                            child.position.end.offset)
+      ).join('').trim();
       const id = getId(`${realFilename}_${headingText}`, idCounters);
 
       const hasStability = node.stability !== undefined;