net: check autoSelectFamilyAttemptTimeout is positive

In document, `autoSelectFamilyAttemptTimeout` is described as positive integer because it's time unit. But there is no checking whether it's positive integer. PR-URL: #45740 Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#socketconnectoptions-connectlistener Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Dec 13, 2022 · b9c2fc7 · b9c2fc7
1 parent 4c51c5c
commit b9c2fc7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/net.js b/lib/net.js
@@ -1210,7 +1210,7 @@ function lookupAndConnect(self, options) {
   }
 
   if (autoSelectFamilyAttemptTimeout !== undefined) {
-    validateInt32(autoSelectFamilyAttemptTimeout);
+    validateInt32(autoSelectFamilyAttemptTimeout, 'options.autoSelectFamilyAttemptTimeout', 1);
 
     if (autoSelectFamilyAttemptTimeout < 10) {
       autoSelectFamilyAttemptTimeout = 10;

diff --git a/test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js b/test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js
@@ -0,0 +1,14 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const net = require('net');
+
+for (const autoSelectFamilyAttemptTimeout of [-10, 0]) {
+  assert.throws(() => {
+    net.connect({
+      port: 8080,
+      autoSelectFamily: true,
+      autoSelectFamilyAttemptTimeout,
+    });
+  }, { code: 'ERR_OUT_OF_RANGE' });
+}