src: use unique_ptr for obj in SetWeak lambda

PR-URL: #23117 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Oct 3, 2018 · ce7fad5 · ce7fad5
1 parent 23525b0
commit ce7fad5
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/base_object-inl.h b/src/base_object-inl.h
@@ -95,13 +95,12 @@ void BaseObject::MakeWeak() {
   persistent_handle_.SetWeak(
       this,
       [](const v8::WeakCallbackInfo<BaseObject>& data) {
-        BaseObject* obj = data.GetParameter();
+        std::unique_ptr<BaseObject> obj(data.GetParameter());
         // Clear the persistent handle so that ~BaseObject() doesn't attempt
         // to mess with internal fields, since the JS object may have
         // transitioned into an invalid state.
         // Refs: https://github.com/nodejs/node/issues/18897
         obj->persistent_handle_.Reset();
-        delete obj;
       }, v8::WeakCallbackType::kParameter);
 }