test: remove common.hasSmallICU

common.hasSmallICU is used in only one test and is a one-liner. Move into the test where it is used to chip away at the `common` monolith. PR-URL: #22937 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Sep 21, 2018 · d38ce82 · d38ce82
1 parent ace6e07
commit d38ce82
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/test/common/README.md b/test/common/README.md
@@ -158,11 +158,6 @@ Indicates `hasCrypto` and `crypto` with fips.
 
 Indicates if [internationalization] is supported.
 
-### hasSmallICU
-* [&lt;boolean>]
-
-Indicates `hasIntl` and `small-icu` are supported.
-
 ### hasIPv6
 * [&lt;boolean>]
 

diff --git a/test/common/index.js b/test/common/index.js
@@ -33,8 +33,7 @@ const { fixturesDir } = require('./fixtures');
 const tmpdir = require('./tmpdir');
 const {
   bits,
-  hasIntl,
-  hasSmallICU
+  hasIntl
 } = process.binding('config');
 
 const noop = () => {};
@@ -712,7 +711,6 @@ module.exports = {
   hasIntl,
   hasCrypto,
   hasIPv6,
-  hasSmallICU,
   hasMultiLocalhost,
   isAIX,
   isAlive,

diff --git a/test/parallel/test-icu-data-dir.js b/test/parallel/test-icu-data-dir.js
@@ -1,7 +1,9 @@
 'use strict';
 const common = require('../common');
 const os = require('os');
-if (!(common.hasIntl && common.hasSmallICU))
+
+const { hasSmallICU } = process.binding('config');
+if (!(common.hasIntl && hasSmallICU))
   common.skip('missing Intl');
 
 const assert = require('assert');