http: fix close return value mismatch between doc and implementation

PR-URL: #51797 Fixes: #51787 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
nodejs · Feb 27, 2024 · ec17fd7 · ec17fd7
1 parent 5f94912
commit ec17fd7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -561,6 +561,7 @@ ObjectSetPrototypeOf(Server, net.Server);
 Server.prototype.close = function() {
   httpServerPreClose(this);
   ReflectApply(net.Server.prototype.close, this, arguments);
+  return this;
 };
 
 Server.prototype[SymbolAsyncDispose] = async function() {

diff --git a/lib/https.js b/lib/https.js
@@ -111,6 +111,7 @@ Server.prototype.setTimeout = HttpServer.prototype.setTimeout;
 Server.prototype.close = function() {
   httpServerPreClose(this);
   ReflectApply(tls.Server.prototype.close, this, arguments);
+  return this;
 };
 
 Server.prototype[SymbolAsyncDispose] = async function() {

diff --git a/test/parallel/test-http-server.js b/test/parallel/test-http-server.js
@@ -139,4 +139,5 @@ process.on('exit', function() {
   assert.match(server_response, quit);
 
   assert.strictEqual(client_got_eof, true);
+  assert.strictEqual(server.close(), server);
 });