stream: fix respondWithNewView() errors when view.byteOffset != 0

Fixes: #42851 Refs: https://github.com/whatwg/streams/blob/f894acdd417926a2121710803cef593e15127964/reference-implementation/lib/abstract-ops/readable-streams.js#L1756 PR-URL: #46465 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
nodejs · Apr 5, 2023 · ed2faa7 · ed2faa7
1 parent ea71a2a
commit ed2faa7
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
@@ -2965,7 +2965,7 @@ function readableByteStreamControllerRespondWithNewView(controller, view) {
   if (byteOffset + bytesFilled !== viewByteOffset)
     throw new ERR_INVALID_ARG_VALUE.RangeError('view', view);
 
-  if (bytesFilled + viewByteOffset > byteLength)
+  if (bytesFilled + viewByteLength > byteLength)
     throw new ERR_INVALID_ARG_VALUE.RangeError('view', view);
 
   if (bufferByteLength !== viewBufferByteLength)

diff --git a/test/parallel/test-whatwg-readablestream.js b/test/parallel/test-whatwg-readablestream.js
@@ -1657,3 +1657,33 @@ class Source {
   reader.read(new DataView(buffer))
     .then(common.mustCall());
 }
+
+{
+  const stream = new ReadableStream({
+    type: 'bytes',
+    autoAllocateChunkSize: 128,
+    pull: common.mustCall((controller) => {
+      const view = controller.byobRequest.view;
+      const dest = new Uint8Array(
+        view.buffer,
+        view.byteOffset,
+        view.byteLength
+      );
+      dest.fill(1);
+      controller.byobRequest.respondWithNewView(dest);
+    }),
+  });
+
+  const reader = stream.getReader({ mode: 'byob' });
+
+  const buffer = new ArrayBuffer(10);
+  const view = new Uint8Array(
+    buffer,
+    1,
+    3
+  );
+
+  reader.read(view).then(common.mustCall(({ value }) => {
+    assert.deepStrictEqual(value, new Uint8Array([1, 1, 1]));
+  }));
+}