From f08f154fd6933d5fb0da3068fa1ff7352bb98171 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Mon, 3 Jun 2019 09:09:45 -0400 Subject: [PATCH] test: update postmortem metadata test for V8 7.6 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The following metadata has changed: - v8dbg_class_FixedTypedArrayBase__base_pointer__Object - Field moved from FixedTypedArrayBase to JSTypedArray. - Postmortem tools should use v8dbg_class_JSTypedArray__base_pointer__Object. - Refs: https://github.com/v8/v8/commit/70bd7cf0ef618621c16ae3f5ba2db614ac8ef996 - v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t - Field moved from FixedTypedArrayBase to JSTypedArray. - Add new constant: v8dbg_class_JSTypedArray__external_pointer__uintptr_t - Refs: https://github.com/v8/v8/commit/70bd7cf0ef618621c16ae3f5ba2db614ac8ef996 - v8dbg_class_Map__instance_descriptors_offset - Underlying constant was renamed to kInstanceDescriptorsOffset. - Postmortem tools should not need to update anything for this constant. - Refs: https://github.com/v8/v8/commit/15a7e04eec8b98c0430960a966a57d1b2ea4aa76 Backport-PR-URL: https://github.com/nodejs/node/pull/28955 PR-URL: https://github.com/nodejs/node/pull/28016 Reviewed-By: Colin Ihrig Reviewed-By: Refael Ackermann (רפאל פלחי) Reviewed-By: Rich Trott Reviewed-By: Michael Dawson Reviewed-By: Jiawen Geng --- test/v8-updates/test-postmortem-metadata.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/v8-updates/test-postmortem-metadata.js b/test/v8-updates/test-postmortem-metadata.js index 3dacc97388993d..790d0dbb5c29b5 100644 --- a/test/v8-updates/test-postmortem-metadata.js +++ b/test/v8-updates/test-postmortem-metadata.js @@ -66,8 +66,8 @@ function getExpectedSymbols() { 'v8dbg_class_ConsString__second__String', 'v8dbg_class_FixedArray__data__uintptr_t', 'v8dbg_class_FixedArrayBase__length__SMI', - 'v8dbg_class_FixedTypedArrayBase__base_pointer__Object', - 'v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t', + 'v8dbg_class_JSTypedArray__base_pointer__Object', + 'v8dbg_class_JSTypedArray__external_pointer__uintptr_t', 'v8dbg_class_HeapNumber__value__double', 'v8dbg_class_HeapObject__map__Map', 'v8dbg_class_JSArray__length__Object',