Skip to content

Commit

Permalink
build: do not disable inspector when intl is disabled
Browse files Browse the repository at this point in the history
PR-URL: #37954
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
  • Loading branch information
Trott authored and danielleadams committed Apr 5, 2023
1 parent 48cd712 commit ff07aa7
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@
action='store_const',
dest='with_intl',
const='none',
help='Disable Intl, same as --with-intl=none (disables inspector)')
help='Disable Intl, same as --with-intl=none')

intl_optgroup.add_argument('--with-icu-path',
action='store',
Expand Down Expand Up @@ -1977,7 +1977,6 @@ def icu_download(path):

def configure_inspector(o):
disable_inspector = (options.without_inspector or
options.with_intl in (None, 'none') or
options.without_ssl)
o['variables']['v8_enable_inspector'] = 0 if disable_inspector else 1

Expand Down

0 comments on commit ff07aa7

Please sign in to comment.