-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Malformed "url" parameter in "Debugger.scriptParsed" event #10838
Comments
/cc @nodejs/v8-inspector |
/cc @roblourens |
Our problem is a little similar at #10672 . I can't map files in chrome workspace. |
Should this remain open? |
It's a legitimate bug: the inspector uses the script name as the URL, but it's a file path in node.js. Although it can be overridden by inserting a edit: pre-existing bug report: https://bugs.chromium.org/p/chromium/issues/detail?id=679144 |
The Dev Tools frontend has already implemented a workaround: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js?l=485&rcl=0a99285795ade2dd281995dee72fdb9e80d3fd6d It's just a matter of getting that into V8. |
That won't work for Windows file paths. |
╮(╯_╰)╭
Then I use inline sourcemap in |
@j3l11234 Tried your solution with no lack. I have tested it with various paths in the |
╮(╯_╰)╭ |
@j3l11234 this is definitely a "that one little that worked" 😱 👍 |
╮(╯_╰)╭ |
╮(╯_╰)╭ |
When I run node with |
Should be fixed in Node 10.12. |
It's been fixed in devtools (diff) so I'm going to go ahead and close this out. |
Debugger.scriptParsed
events contain malformed"url"
parameter values, like:Here
"url"
is set to"C:\\Users\\Sergey.Simonchik\\simple-example\\foo.js"
which is an invalid URL.According to https://chromium.googlesource.com/v8/v8/+/master/src/inspector/js_protocol.json, "url" parameter of "scriptParsed" event is defined as
Probably, the expected value should be
"file://C:\\Users\\Sergey.Simonchik\\simple-example\\foo.js"
The text was updated successfully, but these errors were encountered: