Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-API code coverage #12219

Closed
mhdawson opened this issue Apr 4, 2017 · 1 comment
Closed

N-API code coverage #12219

mhdawson opened this issue Apr 4, 2017 · 1 comment
Labels
node-api Issues and PRs related to the Node-API.

Comments

@mhdawson
Copy link
Member

mhdawson commented Apr 4, 2017

  • Version: master
  • Platform: all
  • Subsystem: n-api

Not a surprise but code coverage for n-api is lower than we'd like: https://coverage.nodejs.org/coverage-a5f91ab230c574d5/cxxcoverage._home_iojs_build_workspace_node-test-commit-linux-coverage_nodes_benchmark_out_.._src_node_api.cc.html

This probably was the cause for the 1.4% drop last night in the C++ coverage.

Opening this issue to that we focus on addressing this and include as part of our more comprehensive call to arms blog going out next week.

fyi @nodejs/n-api

@mscdex mscdex added addons Issues and PRs related to native addons. node-api Issues and PRs related to the Node-API. and removed addons Issues and PRs related to native addons. labels Apr 4, 2017
@mhdawson
Copy link
Member Author

Coverage is now up to 91.9% which is higher than the overall average, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

No branches or pull requests

2 participants