-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: beware review comments for long diffs #12554
Comments
I would report it, just to be safe. |
I've reported via 'Contact GitHub'. Till fixed, maybe we could split very big docs into several parts for review time. |
Fwiw I also ran into this quite a few times when reviewing the original N-API PR, just describing the location where the comment was supposed to end up worked okay in the end |
GitHub Staff answer:
|
This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that. |
See: #12549 (comment)
I am not sure if this is a known bug and if we should report it to GitHub.
The text was updated successfully, but these errors were encountered: