Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: beware review comments for long diffs #12554

Closed
vsemozhetbyt opened this issue Apr 20, 2017 · 5 comments
Closed

meta: beware review comments for long diffs #12554

vsemozhetbyt opened this issue Apr 20, 2017 · 5 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@vsemozhetbyt
Copy link
Contributor

See: #12549 (comment)

I am not sure if this is a known bug and if we should report it to GitHub.

@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Apr 20, 2017
@jasnell
Copy link
Member

jasnell commented Apr 20, 2017

I would report it, just to be safe.

@vsemozhetbyt
Copy link
Contributor Author

I've reported via 'Contact GitHub'. Till fixed, maybe we could split very big docs into several parts for review time.

@addaleax
Copy link
Member

Fwiw I also ran into this quite a few times when reviewing the original N-API PR, just describing the location where the comment was supposed to end up worked okay in the end

@vsemozhetbyt
Copy link
Contributor Author

GitHub Staff answer:

Thanks for the report! Our team is aware of this issue. I can't promise an ETA for when it might be fixed, but it is on our radar and we'll be sure to write back as soon as we have news.

@Trott
Copy link
Member

Trott commented Aug 2, 2017

This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.

@Trott Trott closed this as completed Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

4 participants