Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky sequential/test-timers-set-interval-excludes-callback-duration #18160

Closed
Trott opened this issue Jan 15, 2018 · 1 comment
Closed
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Comments

@Trott
Copy link
Member

Trott commented Jan 15, 2018

  • Version: 10.0-pre
  • Platform: ubuntu1604_sharedlibs_debug_x64
  • Subsystem: test

https://ci.nodejs.org/job/node-test-commit-linux-containered/1416/nodes=ubuntu1604_sharedlibs_debug_x64/console

03:37:24 not ok 2014 sequential/test-timers-set-interval-excludes-callback-duration
03:37:24   ---
03:37:24   duration_ms: 1.220
03:37:24   severity: fail
03:37:24   stack: |-
03:37:24     assert.js:45
03:37:24       throw new errors.AssertionError(obj);
03:37:24       ^
03:37:24     
03:37:24     AssertionError [ERR_ASSERTION]: false == true
03:37:24         at Timeout.setInterval [as _onTimeout] (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/test/sequential/test-timers-set-interval-excludes-callback-duration.js:14:5)
03:37:24         at ontimeout (timers.js:455:11)
03:37:24         at tryOnTimeout (timers.js:304:5)
03:37:24         at Timer.listOnTimeout (timers.js:267:5)
03:37:24   ...

/cc @apapirovski

@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. test Issues and PRs related to the tests. labels Jan 15, 2018
@apapirovski
Copy link
Member

Should be easy to resolve. I think I was just too optimistic last time with the comparison value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants