-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport Chromium:666046 for Node 6.x #21389
Comments
/cc @codebytere as you were interested in helping out. This fix itself looks small enough so hopefully the back-port isn't tremendously complicated. I'd be happy to help |
@ofrobots thanks, i'll take a stab at it! |
@codebytere seems for me like it's a good change to contribute, isn't it? Are you going to do this or I can take it? (and ping you for a review if you'd like) |
Oh, it's already been done:
and landed a while ago. It's weird that this issue seems fresh and the chromium issue doesn't have any updates about it. |
@vitkarpov oh you're right, bummer but glad it's been taken care of! |
Anything else which could be taken care of? ;) Looking for another issue. |
@vitkarpov thanks a lot for taking a look. My bad for losing track of the issue already being fixed in Node 😬. I've updated the chromium issue. There are few more issues I am planning to open next week for potential backports, keep an eye on the 'V8 Engine' and 'help wanted' labels. |
Chromium:666046 is a bug known to affect Node 6.x. A fix is available that needs to be back-ported to Node 6.x.
For full details on how we manage the V8 branches in Node release lines see this doc.
The text was updated successfully, but these errors were encountered: