Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icu build: use genccode -o on non-windows platforms #21695

Closed
srl295 opened this issue Jul 6, 2018 · 2 comments
Closed

icu build: use genccode -o on non-windows platforms #21695

srl295 opened this issue Jul 6, 2018 · 2 comments
Assignees
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Jul 6, 2018

  • Platform: all
  • Subsystem: deps

some (all?) non-windows platforms we build on, could support ICU's .dat-to-.obj file conversion via assembler, but right now it's only enabled on windows. Others get:

generating C code for /Users/srl/src/node/out/Release/obj/gen/icudt62.dat
  CC(target) /Users/srl/src/node/out/Release/obj.target/icudata/gen/icudt62_dat.o

…and yes, that's a hefty .c file. i found/refound this when @bnoordhuis started re-implementing what ICU aready supports.

I think a small whitelist of compilers/platforms might suffice: gcc/linux, gcc/aix, gcc/mac, gcc/mingw, gcc/solaris ( Hmm, I guess that's just one compiler)

On windows, we use the -o option which outputs a .obj file directly with no intermediate files.

advantage would be to speed up the build a little bit, probably reduce max memory/swap footprint.

@srl295 srl295 changed the title use genccode -o on non-windows platforms icu build: use genccode -o on non-windows platforms Jul 6, 2018
@srl295 srl295 self-assigned this Jul 6, 2018
@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Jul 6, 2018
@richardlau
Copy link
Member

@srl295 Was this part of #29522 (I seem to recall some discussion there about assemblers)?

@srl295
Copy link
Member Author

srl295 commented Nov 22, 2019

@srl295 Was this part of #29522 (I seem to recall some discussion there about assemblers)?

Good catch! Yes, I did this in #29522

@srl295 srl295 closed this as completed Nov 22, 2019
@srl295 srl295 added the build Issues and PRs related to build files or the CI. label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Development

No branches or pull requests

2 participants