Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collaborator nomination: @rubys #21974

Closed
Trott opened this issue Jul 25, 2018 · 21 comments
Closed

Collaborator nomination: @rubys #21974

Trott opened this issue Jul 25, 2018 · 21 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@Trott
Copy link
Member

Trott commented Jul 25, 2018

I'd like to nominate Sam Ruby (@rubys) as a Collaborator. They have been a joy to work with so far and have done some impressive work.

PRs in Node core
Comments on Issues and PRs in Node core
@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Jul 25, 2018
@richardlau richardlau mentioned this issue Jul 25, 2018
Closed
@Trott
Copy link
Member Author

Trott commented Jul 25, 2018

@nodejs/collaborators (Sorry, but our GOVERNANCE doc says to mention the whole group, so there you go.)

@gireeshpunathil
Copy link
Member

+1

@benjamingr
Copy link
Member

I think mentioning the whole group in case anyone has any valid information about the contributor is fair. It's one of the cases where I like a ping.

+1

@refack
Copy link
Contributor

refack commented Jul 25, 2018

+1

@maclover7
Copy link
Contributor

+1, thank you for all of the awesome work on docs generation!

@jasnell
Copy link
Member

jasnell commented Jul 26, 2018

+1 for certain

@cjihrig
Copy link
Contributor

cjihrig commented Jul 26, 2018

+1

2 similar comments
@apapirovski
Copy link
Member

+1

@trivikr
Copy link
Member

trivikr commented Jul 26, 2018

+1

@vsemozhetbyt
Copy link
Contributor

+1, thank you.

@BridgeAR
Copy link
Member

+1

@benjamingr
Copy link
Member

@rubys can you please state that you are interested :)?

@rubys
Copy link
Member

rubys commented Jul 26, 2018

I'm interested.

@yhwang
Copy link
Member

yhwang commented Jul 26, 2018

+1

1 similar comment
@ChALkeR
Copy link
Member

ChALkeR commented Jul 26, 2018

+1

@jasnell
Copy link
Member

jasnell commented Jul 27, 2018

@rubys ... Assuming there are no objections in the next day or so, let's get some time scheduled late next week or the following to go through the onboarding. Won't take long. :) I'll message you privately to get times set up.

@benjamingr
Copy link
Member

@jasnell as far as I know our policy requires it to be open for a week, personally I don't mind it happening sooner (but others might object).

@rubys
Copy link
Member

rubys commented Jul 27, 2018

It is scheduled for Friday - a week from today.

@mhdawson
Copy link
Member

+1

@bcoe
Copy link
Contributor

bcoe commented Aug 3, 2018

strong +1, @rubys gave me wonderful feedback on the mkdirp pull request I've been working on.

@Trott
Copy link
Member Author

Trott commented Aug 3, 2018

Onboarding happened today! 🎉

@Trott Trott closed this as completed Aug 3, 2018
@snyk-bot snyk-bot mentioned this issue Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests