You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the solution you'd like
I've been reading the Testing for internet and I've seen the function killChildren repeatedly defined over many files, such as test/internet/test-dgram-multicast-set-interface-lo.js and test/internet/test-dgram-broadcast-multi-process.js, and other similar patterns
Describe alternatives you've considered
I was wondering if it was a good idea to add a process module inside the common library so to not repeat code inside the tests. Otherwise we could add a Utils library.
Thanks!
The text was updated successfully, but these errors were encountered:
Tests are the one place where it doesn't always make sense to keep could DRY. (See https://stackoverflow.com/q/6453235/436641 for example.) And this function is tiny. Abstracting it out does not gain us much. It appears in three tests.
I wouldn't stop it if someone wanted to do it, but I wouldn't bother.
Describe the solution you'd like
I've been reading the Testing for internet and I've seen the function
killChildren
repeatedly defined over many files, such astest/internet/test-dgram-multicast-set-interface-lo.js
andtest/internet/test-dgram-broadcast-multi-process.js
, and other similar patternsDescribe alternatives you've considered
I was wondering if it was a good idea to add a process module inside the common library so to not repeat code inside the tests. Otherwise we could add a
Utils
library.Thanks!
The text was updated successfully, but these errors were encountered: