Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--abort_on_uncaught_exception causes exception stack dumps to be incorrect #22848

Closed
rick-rheo opened this issue Sep 13, 2018 · 2 comments
Closed
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. v8 engine Issues and PRs related to the V8 dependency.

Comments

@rick-rheo
Copy link

Version: v8.11.3
Platform: MacOS and any Linux.

When using --abort_on_uncaught_exception exceptions do not include line numbers in stack trace.

here's what happens with an exception with the option enabled

$ node -max-old-space-size=2000 --abort_on_uncaught_exception --stack_trace_on_illegal server/appInstances/serverInstance.js v=production

Uncaught TypeError: service.getTags is not a function

FROM
LibraryServiceModule.getMicroService (/Volumes/code/LibraryService+r_0.0.553/server/appInstances/serverInstance.js:1:1)
Immediate.setImmediate (/Volumes/code/LibraryService+r_0.0.553/server/lib/utils.js:1:1)
runCallback (timers.js:1:1)
tryOnImmediate (timers.js:1:1)
processImmediate [as _immediateCallback] (timers.js:1:1)
Illegal instruction: 4

And here's without it


$ node -max-old-space-size=2000 --stack_trace_on_illegal server/appInstances/serverInstance.js v=production

TypeError: service.getTags is not a function
    at LibraryServiceModule.getMicroService (/Volumes/code/LibraryService+r_0.0.553/server/appInstances/serverInstance.js:33:25)
    at Immediate.setImmediate [as _onImmediate] (/Volumes/code/LibraryService+r_0.0.553/server/lib/utils.js:64:25)
    at runCallback (timers.js:810:20)
    at tryOnImmediate (timers.js:768:5)
    at processImmediate [as _immediateCallback] (timers.js:745:5) 


@addaleax addaleax added v8 engine Issues and PRs related to the V8 dependency. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. duplicate Issues and PRs that are duplicates of other issues or PRs. labels Sep 13, 2018
@addaleax
Copy link
Member

Thanks for the bug report! This looks like a duplicate of #21988, so I’ll be closing this issue. Feel free to let us know if I’m mistaken here!

@rick-rheo
Copy link
Author

OK yeah, I assumed that someone would've run into this by now but searching on abort_on_uncaught_exception brought up nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

2 participants