Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote debugger unable to convert path correctly in different operating system #23688

Open
s97712 opened this issue Oct 16, 2018 · 7 comments
Open
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. inspector Issues and PRs related to the V8 inspector protocol

Comments

@s97712
Copy link

s97712 commented Oct 16, 2018

  • Version:v10.9.0
  • Platform:Linux s97712 4.18.10-arch1-1-ARCH deps: update openssl to 1.0.1j #1 SMP PREEMPT Wed Sep 26 09:48:22 UTC 2018 x86_64 GNU/Linux
  • Subsystem:remote debugger

I debugger node on window, but my node server on linux.
When I set the breakpoint through chrome devtools, like the below:
image
It doesn't work, nothing happend when reach breakpoint.

I inspect the devtools through chrome://inspect/#pages
image

the devtools check the operating system with Host.isWin() , but it check the local operating system, not remote
image

image

@addaleax addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Oct 16, 2018
@addaleax
Copy link
Member

@nodejs/v8-inspector

@eugeneo
Copy link
Contributor

eugeneo commented Oct 16, 2018

This is a Chrome DevTools issue. CC: @aslushnikov

@alexkozy
Copy link
Member

alexkozy commented Oct 16, 2018

Thanks for nice bug report.
This issue is fixed in latest Node 10.12 (node uses file urls in protocol instead of platform specific paths) and Chrome >= 71. You can try to use Chrome Canary on Windows.

@targos
Copy link
Member

targos commented Oct 16, 2018

It looks like we landed the fix too soon? Should we revert until Chrome 71 is stable?

@alexkozy
Copy link
Member

Would it be possible to reland it in 6 weeks? It looks like Node 10 will go to LTS before.
Revert SGTM.

@targos
Copy link
Member

targos commented Oct 17, 2018

Would it be possible to reland it in 6 weeks?

Sure. I suppose #22251 is the PR? Do we need to revert all 3 commits?

@Trott
Copy link
Member

Trott commented Nov 29, 2018

What's the status of this?

@jasnell jasnell added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

No branches or pull requests

7 participants