-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs.promises FileHandle.read() not working with object argument as stated in docs. #34176
Comments
Problem confirmed on Windows 10. You can see diagnosis of the problem here: https://stackoverflow.com/questions/62704475/node-js-filehandle-read-method-throws-invalid-argument-error/62704825. The implementation of |
PR-URL: #34180 Fixes: #34176 Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #34180 Fixes: #34176 Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #34180 Fixes: #34176 Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #34180 Fixes: #34176 Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
What steps will reproduce the bug?
Using FileHandle.read() with object argument.
This example throws
TypeError
:How often does it reproduce? Is there a required condition?
Everytime you use object as argument.
What is the expected behavior?
Method should accept object as parameter, as stated in docs here.
What do you see instead?
Additional information
This bug dosen't seem too complicated, maybe I could fix it.
The text was updated successfully, but these errors were encountered: