Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node:test] concurrency type and default value #45643

Closed
Semigradsky opened this issue Nov 27, 2022 · 6 comments
Closed

[node:test] concurrency type and default value #45643

Semigradsky opened this issue Nov 27, 2022 · 6 comments
Assignees
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. test_runner Issues and PRs related to the test runner subsystem.

Comments

@Semigradsky
Copy link
Contributor

Affected URL(s)

https://nodejs.org/docs/latest-v18.x/api/test.html

Description of the problem

By https://nodejs.org/docs/latest-v18.x/api/test.html#testname-options-fn we have concurrency field in options which can be number or boolean with defaut value false.
image


By https://nodejs.org/docs/latest-v18.x/api/test.html#contexttestname-options-fn we have concurrency field in options which can be only number with defaut value 1.
image
But looks like options should be the same:
https://github.com/nodejs/node/blob/v18.x/lib/internal/test_runner/test.js#L126-L131


By https://nodejs.org/docs/latest-v18.x/api/test.html#runoptions we have concurrency field in options which can be number or boolean with defaut value true.
image
Should the default value be different from that in test?

@Semigradsky Semigradsky added the doc Issues and PRs related to the documentations. label Nov 27, 2022
@MoLow MoLow added good first issue Issues that are suitable for first-time contributors. and removed doc Issues and PRs related to the documentations. labels Nov 27, 2022
@MoLow
Copy link
Member

MoLow commented Nov 27, 2022

this should accept boolean as well

@MoLow MoLow added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Nov 27, 2022
@Semigradsky
Copy link
Contributor Author

Pay attention to different default values also.

@WonJo-Jung
Copy link

WonJo-Jung commented Nov 29, 2022

I'd like to get breakthrough about this issue. @MoLow could you assign this issue to me? :)

@WonJo-Jung
Copy link

WonJo-Jung commented Dec 6, 2022

I checked context.test() and run() are configuring option values like test(), except default value of concurrency field is 1, not false. So I think next step would be revising document about test_runner. Is my suggestion correct? Or other steps remain?

@MoLow
Copy link
Member

MoLow commented Feb 6, 2023

fixed by 7d68b7b

@MoLow MoLow closed this as completed Feb 6, 2023
@MoLow
Copy link
Member

MoLow commented Feb 6, 2023

thanks @richiemccoll 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants