-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node:test] concurrency
type and default value
#45643
Comments
this should accept boolean as well |
Pay attention to different default values also. |
I'd like to get breakthrough about this issue. @MoLow could you assign this issue to me? :) |
I checked |
fixed by 7d68b7b |
thanks @richiemccoll 🎉 |
Affected URL(s)
https://nodejs.org/docs/latest-v18.x/api/test.html
Description of the problem
By https://nodejs.org/docs/latest-v18.x/api/test.html#testname-options-fn we have
concurrency
field inoptions
which can benumber
orboolean
with defaut valuefalse
.By https://nodejs.org/docs/latest-v18.x/api/test.html#contexttestname-options-fn we have
concurrency
field inoptions
which can be onlynumber
with defaut value1
.But looks like options should be the same:
https://github.com/nodejs/node/blob/v18.x/lib/internal/test_runner/test.js#L126-L131
By https://nodejs.org/docs/latest-v18.x/api/test.html#runoptions we have
concurrency
field inoptions
which can benumber
orboolean
with defaut valuetrue
.Should the default value be different from that in
test
?The text was updated successfully, but these errors were encountered: