-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP/2 server.close() is broken with "allowHTTP1" mode #51493
Comments
I creating a PR for this |
xsbchen
added a commit
to xsbchen/node
that referenced
this issue
Jan 26, 2024
xsbchen
added a commit
to xsbchen/node
that referenced
this issue
Jan 30, 2024
xsbchen
added a commit
to xsbchen/node
that referenced
this issue
Jan 31, 2024
nodejs-github-bot
pushed a commit
that referenced
this issue
Feb 1, 2024
Fixes: #51493 PR-URL: #51569 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this issue
Feb 9, 2024
Fixes: nodejs#51493 PR-URL: nodejs#51569 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
targos
pushed a commit
that referenced
this issue
Feb 15, 2024
Fixes: #51493 PR-URL: #51569 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this issue
Feb 19, 2024
Fixes: nodejs#51493 PR-URL: nodejs#51569 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
richardlau
pushed a commit
that referenced
this issue
Mar 25, 2024
Fixes: #51493 PR-URL: #51569 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
richardlau
pushed a commit
that referenced
this issue
Mar 25, 2024
Fixes: #51493 PR-URL: #51569 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v21.6.0
Platform
Darwin Kernel Version 19.6.0
Subsystem
none
What steps will reproduce the bug?
Run the script below:
How often does it reproduce? Is there a required condition?
I can reliably reproduce it 100% of the time.
What is the expected behavior? Why is that the expected behavior?
The expected behavior is for the HTTPS server to close down immediately (as soon as the request ends). This is what happens when using
https.createServer()
, as demonstrated by changingUSE_COMPATIBILITY_MODE
tofalse
in the script above.What do you see instead?
Instead, the HTTPS server stays open for 5 seconds (which is the default keep-alive duration).
In other words, calling
server.close()
properly shuts down idle "keep-alive" sockets when using thehttp
orhttps
modules, but not when using thehttp2
module withallowHTTP1: true
.Additional information
You'll need a TLS certificate to run the script above. I created one by following this guide in the Node.js documentation to create a self-signed certificate.
The text was updated successfully, but these errors were encountered: