-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v18.x] Wrong path returned by fs.readdir withFileTypes=true #52441
Comments
cc @aduh95 |
hi guys, what's the status of this issue? I can look into it if it wasn't assigned to anyone yet |
@gm-al Basically waiting for a PR, feel free to work on it if you want :) You can ping me when you had something to review |
Just had a quick scan, looks like the current main does not have |
Hello! May I try to resolve this issue? |
…addir' The issue was caused by a modification in PR nodejs#51021 , which was working on including the parentPath in the documentation and modifying the path to display the filepath. I have retained the content related to the documentation and removed the filepath part. Fixes: nodejs#52441 Co-authored-by: daeyoen <[email protected]> Co-authored-by: injae-kim <[email protected]>"
The issue was caused by a modification in PR nodejs#51021, which included changes to the documentation for parentPath and modifications to display the filepath. I have retained the content related to the documentation and removed the filepath part. Fixes: nodejs#52441 Co-authored-by: injae-kim <[email protected]>
The issue was caused by a modification in PR nodejs#51021, which included changes to the documentation for parentPath and modifications to display the filepath. I have retained the content related to the documentation and removed the filepath part. Fixes: nodejs#52441 Co-authored-by: injae-kim <[email protected]>
The issue was caused by a modification in PR nodejs#51021, which included changes to the documentation for parentPath and modifications to display the file path. I have retained the content related to the documentation and removed the filepath part. Fixes: nodejs#52441 Co-authored-by: injae-kim <[email protected]>
Version
18.20.1
Platform
Linux h4ad 6.5.0-27-generic #28~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Fri Mar 15 10:51:06 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
fs/promise
What steps will reproduce the bug?
You can reproduce the issue by running the following commands:
How often does it reproduce? Is there a required condition?
Always
What is the expected behavior? Why is that the expected behavior?
The path should be
.
.What do you see instead?
The path is different:
This issue only happens on
fs/promises
, onreaddirSync
, we don't see this issue:Also, if we include
recursive
, we don't see the issue:Additional information
This bug was first introduced at
18.20.0
, on18.19.1
the behavior is correct.On latest version of node,
21.7.2
and20.12.1
, we don't see this issue.This bug was found by @wraithgar at npm/cli#7352 (comment)
The text was updated successfully, but these errors were encountered: