Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move .eslintrc to json or yaml #6131

Closed
AdriVanHoudt opened this issue Apr 9, 2016 · 6 comments
Closed

Move .eslintrc to json or yaml #6131

AdriVanHoudt opened this issue Apr 9, 2016 · 6 comments
Labels
tools Issues and PRs related to the tools directory.

Comments

@AdriVanHoudt
Copy link
Contributor

  • Version: All
  • Platform: All
  • Subsystem: Tools?

The old .eslintrc style is deprecated (http://eslint.org/docs/user-guide/configuring#configuration-file-formats)
Would you be open for a PR to move it to .js, .json or .yaml?
I personally prefer .js since it allows comments, as oppose to .json, and I am more familiar with it then .yaml (as I assume most node people)

@silverwind
Copy link
Contributor

It's unlikely that support for .eslintrc is ever to be dropped from ESLint as it would break a lot of tooling. I personally prefer the YAML format heavily because it doesn't require quotes and braces everywhere.

The only upside to the extensions is that it allows editors to pick the correct syntax highlighting based on the extension. Also, having a extension on dotfiles seems a bit strange to me, .somethingrc is a pretty common convention for dotfiles. I'm -1 on changing it.

@silverwind silverwind added the tools Issues and PRs related to the tools directory. label Apr 9, 2016
@AdriVanHoudt
Copy link
Contributor Author

I understand your points. They could remove support in a version 3 since it is deprecated though.

@Fishrock123
Copy link
Contributor

we'll probably change it to .yaml once it breaks.

@silverwind
Copy link
Contributor

I understand your points. They could remove support in a version 3 since it is deprecated though.

As I said, that's highly unlikely. The author said:

We don't have to remove support, but I want to encourage people to use the more specific file formats.

@AdriVanHoudt
Copy link
Contributor Author

Did not know that, but he encourages the more specific file formats

@AdriVanHoudt
Copy link
Contributor Author

Gonna close this since #7699 will handle this further
Still in favor of non deprecated version but I understand some tools need to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

No branches or pull requests

3 participants