Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does make sense to upgrade V8 to 5.1? #6354

Closed
ghaiklor opened this issue Apr 23, 2016 · 13 comments
Closed

Does make sense to upgrade V8 to 5.1? #6354

ghaiklor opened this issue Apr 23, 2016 · 13 comments
Labels
question Issues that look for answers. v8 engine Issues and PRs related to the V8 dependency.

Comments

@ghaiklor
Copy link
Contributor

V8 team has published new version today - http://v8project.blogspot.com/2016/04/v8-release-51.html - bringing a few performance and GC improvements.

Does it make sense to integrate 5.1 with NodeJS 6.0 or we have no time for this?

@ghaiklor ghaiklor changed the title Does make sense to add V8 5.1? Does make sense to upgrade V8 to 5.1? Apr 23, 2016
@addaleax addaleax added the v8 engine Issues and PRs related to the V8 dependency. label Apr 23, 2016
@addaleax
Copy link
Member

@nodejs/v8

@ChALkeR
Copy link
Member

ChALkeR commented Apr 23, 2016

@ghaiklor It's unstable.

It will get stable in time with Chrome 51 release, which isn't going to happen this month.

@ChALkeR ChALkeR closed this as completed Apr 23, 2016
@ChALkeR ChALkeR added the question Issues that look for answers. label Apr 23, 2016
@ChALkeR
Copy link
Member

ChALkeR commented Apr 23, 2016

It might be time for a vee-eight-5.1 branch, though =).

@ofrobots
Copy link
Contributor

Anyone creating a vee-eight-5.1 might want to look at the (unreviewed) fixes we keep in the vee-eight-lkgr branch over at http://github.com/v8/node.

@jasnell
Copy link
Member

jasnell commented Apr 23, 2016

Let's hold off until it goes stable.

@jasnell
Copy link
Member

jasnell commented Apr 23, 2016

Or is it stable already?

@Fishrock123
Copy link
Contributor

It is not stable.

@seeekr
Copy link

seeekr commented Apr 24, 2016

Question from the sidelines because I have not fully understood this part of the new node release strategy yet:
Once node v6 is released initially, is it going to be fair game to upgrade v8 before the next major node release (v7)? Or will node v6 be "stuck" (too harsh of a term, considering how excellently up to date node is with v8 nowadays thanks to all you guys' efforts!) on the initially chosen v8 version, 5.0, even as node v6 goes into LTS mode in October? Thanks for clarifying!

EDITing to add: With 6 months of runway into an LTS release it seems that upgrading v8 at least up to something like 3 months before a release turns LTS could be a sensible thing to do?
Though the idea with the release/LTS process as the core group has chosen it could of course have been very specifically bound to 6 months of runway on one and the same v8 version, and then my thinking here is off...

@bnoordhuis
Copy link
Member

@seeekr Not unless it's possible to upgrade without breaking API/ABI because that would break add-ons.

With 5.1, that might just be feasible; the API changes have been additive so far (i.e., semver-minor compatible) and the ABI breakage we can probably work around by floating a small patch.

@mgol
Copy link
Contributor

mgol commented May 31, 2016

With 5.1, that might just be feasible; the API changes have been additive so far (i.e., semver-minor compatible) and the ABI breakage we can probably work around by floating a small patch.

@bnoordhuis Does that still apply? V8 5.1 went stable 6 days ago.

I'm asking because V8 5.1 is the first V8 release which passes almost every test on the Kangax ES6 compat table with the exception for proper tail calls so if it was possible to get it into Node 6 it'd help a lot!

@bnoordhuis
Copy link
Member

@mgol Looks like it. See ofrobots#23.

@lin7sh
Copy link

lin7sh commented Jul 4, 2016

It's July already, any plan for the 5.1 release?

@rvagg
Copy link
Member

rvagg commented Jul 5, 2016

see #7016 (comment) for more info on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issues that look for answers. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests