-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does make sense to upgrade V8 to 5.1? #6354
Comments
@nodejs/v8 |
@ghaiklor It's unstable. It will get stable in time with Chrome 51 release, which isn't going to happen this month. |
It might be time for a |
Anyone creating a |
Let's hold off until it goes stable. |
Or is it stable already? |
It is not stable. |
Question from the sidelines because I have not fully understood this part of the new node release strategy yet: EDITing to add: With 6 months of runway into an LTS release it seems that upgrading v8 at least up to something like 3 months before a release turns LTS could be a sensible thing to do? |
@seeekr Not unless it's possible to upgrade without breaking API/ABI because that would break add-ons. With 5.1, that might just be feasible; the API changes have been additive so far (i.e., semver-minor compatible) and the ABI breakage we can probably work around by floating a small patch. |
@bnoordhuis Does that still apply? V8 5.1 went stable 6 days ago. I'm asking because V8 5.1 is the first V8 release which passes almost every test on the Kangax ES6 compat table with the exception for proper tail calls so if it was possible to get it into Node 6 it'd help a lot! |
@mgol Looks like it. See ofrobots#23. |
It's July already, any plan for the 5.1 release? |
see #7016 (comment) for more info on that |
V8 team has published new version today - http://v8project.blogspot.com/2016/04/v8-release-51.html - bringing a few performance and GC improvements.
Does it make sense to integrate 5.1 with NodeJS 6.0 or we have no time for this?
The text was updated successfully, but these errors were encountered: