Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node --inspect support for /json/protocol #7470

Closed
nojvek opened this issue Jun 29, 2016 · 2 comments
Closed

node --inspect support for /json/protocol #7470

nojvek opened this issue Jun 29, 2016 · 2 comments
Labels
inspector Issues and PRs related to the V8 inspector protocol

Comments

@nojvek
Copy link

nojvek commented Jun 29, 2016

Feature request:

There could be times where the node --inspect protocol could divert from chrome's at a minor level. Especially around versioning. There is also node-chakra which at some point I am guessing will support the debugging protocol. It may even add additional debugging features e.g time travel debugging.

There's some prior discussion why chrome doesn't implement a http://localhost:9222/json/protocol call

See cyrus-and/chrome-remote-interface#10
Official crbug: https://bugs.chromium.org/p/chromium/issues/detail?id=538300

The gist I am getting is it adds to the file size. This is a valid reason and I'm all for keeping node lean and mean.

Paul Irish sent a stub to grab the protocol.json file from the version but it seems pretty hacky
cyrus-and/chrome-remote-interface#10 (comment)

Does it make sense for json/protocol to return a public url of where to get the protocol.json for that build of node. It could very well be a versioned github url

e.g https://raw.githubusercontent.com/nodejs/node/44b9154495ede7090e90707898449feb11c5100f/deps/v8_inspector/platform/v8_inspector/js_protocol.json

If this seems like a good idea, I can file a bug on chromium to support a similar API.

We can also make the Edge diagnostics adapter conform to a similar API.

As more tooling and browser vendors start supporting such protocols there will definitely be minor variations around the api. It would be awesome if there would be an automated way to query the engine and generate a table. Sort of like https://caniuse.com.

/cc @paulirish @pavelfeldman @ofrobots @auchenberg @joshgav @rvagg @cyrus-and @kunalspathak

Thoughts?

@nojvek nojvek changed the title node --inspect to support /json/protocol node --inspect support for /json/protocol Jun 29, 2016
@addaleax addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Jun 29, 2016
@auchenberg
Copy link

Already being discussed in the Diagnostics WG. nodejs/diagnostics#52

@nojvek
Copy link
Author

nojvek commented Jun 29, 2016

Oh nice. Closing this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

No branches or pull requests

3 participants